Skip to content

Fix (?) to shared-db testing in microservices.md #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025
Merged

Conversation

qmacro
Copy link
Collaborator

@qmacro qmacro commented Jun 26, 2025

The cds db -2 sql and cds db -2 hana commands are a bit suspect, as the db command doesn't exist. From the paragraph just before these commands, I suspect this should be compile, but even then, we need also to specify the --all option, otherwise we get the message "You must specify a model to compile.".

The `cds db -2 sql` and `cds db -2 hana` commands are a bit suspect, as the `db` command doesn't exist. From the paragraph just before these commands, I suspect this should be `compile`, but even then, we need also to specify the `--all` option, otherwise we get the message "You must specify a model to compile.".
@vl-leon
Copy link
Contributor

vl-leon commented Jun 26, 2025

cds db -2 sql worked in cds 8, but in cds 9 it does not.

compile is the default command, it is documented (cds -h):
cds <src> = cds compile <src>

I would prefer to specify that we do compile the model, meaning cds compile db -2 sql

It looks also as a regression: cds db should resolve to cds compile db.

@vl-leon
Copy link
Contributor

vl-leon commented Jun 26, 2025

I do not see the --all option documented in cds 9, see cds help compile
Documented are -s all and -l all

@renejeglinsky
Copy link
Contributor

Why not use cds compile, so the full command? Is there a need to use the shortcut/default? If not, we should not make our users guess/research what we mean.

@vl-leon
Copy link
Contributor

vl-leon commented Jun 26, 2025

cds compile db -2 sql works

Copy link
Contributor

@renejeglinsky renejeglinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal following @vl-leon's comment

qmacro and others added 2 commits July 3, 2025 11:14
@renejeglinsky renejeglinsky added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 9d50620 Jul 3, 2025
4 checks passed
@renejeglinsky renejeglinsky deleted the qmacro-patch-1 branch July 3, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants